FIX Retry running nvm install - #49
Merged
Merged
Conversation
emteknetnz
marked this pull request as ready for review
July 29, 2026 05:58
emteknetnz
force-pushed
the
pulls/1.2/retry-nvm
branch
from
July 31, 2026 04:29
0aeddd2 to
113338e
Compare
Member
Author
|
Done |
blueo
requested changes
Aug 1, 2026
blueo
left a comment
blueo
left a comment
There was a problem hiding this comment.
The rebase looks like it dropped part of this PR's own change in the doc-linting step. The \. .../nvm-install-retry.sh sourcing line was kept, but the nvm install call below it was reverted to the un-retried form — so the documentation-lint job no longer gets the retry, and the sourced helper is unused there. The JS-tests step is fine. One-line fix inline.
emteknetnz
force-pushed
the
pulls/1.2/retry-nvm
branch
from
August 3, 2026 01:13
113338e to
f37d916
Compare
blueo
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/.github#491
There have been some sporadic failures with nvm installing e.g. https://github.com/silverstripe/silverstripe-mfa/actions/runs/30376907395/job/90334900026 - this will retry installing node if it fails